Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for 'biomass' and 'other' generators #71

Merged
merged 2 commits into from
Dec 16, 2019
Merged

feat: support for 'biomass' and 'other' generators #71

merged 2 commits into from
Dec 16, 2019

Conversation

danielolsen
Copy link
Contributor

This gives PowerSimData the ability to deal with generators of type 'other' and 'biomass'.

@danielolsen danielolsen requested a review from kasparm December 9, 2019 20:04
@danielolsen danielolsen requested a review from rouille December 10, 2019 18:53
@danielolsen danielolsen mentioned this pull request Dec 10, 2019
Merged
@rouille
Copy link
Collaborator

rouille commented Dec 12, 2019

The _check_resource function in change_table.py needs to be updated I would say.

@danielolsen
Copy link
Contributor Author

The _check_resource function in change_table.py needs to be updated I would say.

@rouille good catch, fixed.

@danielolsen
Copy link
Contributor Author

This branch (when combined with add_othertype_gens) has been tested in the context of post-run analysis (via PostREISE calls to analyze Scenario #307) and seems to work properly. Generators of 'other' type are recognized, and summarized properly along with coal generators, gas generators, etc.

rouille
rouille approved these changes Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@danielolsen danielolsen merged commit d15eea8 into develop Dec 16, 2019
@danielolsen danielolsen deleted the add_biomass_other_support branch February 26, 2020 00:48
@ahurli ahurli mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouille rouille rouille approved these changes

@kasparm kasparm Awaiting requested review from kasparm

Assignees

@kasparm kasparm

@rouille rouille

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielolsen @rouille @kasparm