Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creating a grid object for europe model #707

Merged
merged 7 commits into from
Dec 7, 2022
Merged

Enable creating a grid object for europe model #707

merged 7 commits into from
Dec 7, 2022

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Nov 30, 2022

Pull Request doc

Purpose

Add europe_tub as a supported model when instantiating a Grid

What the code is doing

Various refactoring to support this, specifically integrating TUB and FromPyPSA so that both are fully populated.

Testing

wip

Where to look

  • It's helpful to clarify where your new code lives if you moved files around or there could be confusion/

  • What files are most important?

Usage Example/Visuals

How the code can be used and/or images of any graphs, tables or other visuals (not always applicable).

Time estimate

How long will it take for reviewers and observers to understand this code change?

@jenhagg jenhagg self-assigned this Nov 30, 2022
@rouille
Copy link
Collaborator

rouille commented Dec 3, 2022

It's clean. My only question would be, how do we access the profiles in our workflow? The get_pypsa_gen_profile and get_pypsa_demand_profile functions both take a Network object

@jenhagg
Copy link
Collaborator Author

jenhagg commented Dec 4, 2022

It's clean. My only question would be, how do we access the profiles in our workflow? The get_pypsa_gen_profile and get_pypsa_demand_profile functions both take a Network object

We could do that in TUB.build()? Assuming we only want to run scenarios/save profiles for the networks on zenodo.

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks

@jenhagg jenhagg marked this pull request as ready for review December 5, 2022 23:45
@jenhagg jenhagg merged commit c3a806c into develop Dec 7, 2022
@jenhagg jenhagg deleted the jen/tub branch December 7, 2022 20:51
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants