Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused code for reading grid from matfile #704

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Nov 14, 2022

Purpose

Remove code that is not used anymore.

What the code is doing

Remove the reise_to_grid module and related tests since we now load the grid from a .pkl file once a scenario is in the analyze state.

Testing

n/a - testing was done on the new code that replaces this

Time estimate

5 min

@jenhagg jenhagg requested review from rouille and BainanXia November 14, 2022 19:12
@jenhagg jenhagg self-assigned this Nov 14, 2022
@rouille
Copy link
Collaborator

rouille commented Nov 14, 2022

We probably want to remove the casemat_cont module too

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning

@jenhagg jenhagg merged commit 5b6b3a3 into develop Nov 29, 2022
@jenhagg jenhagg deleted the jen/grid branch November 29, 2022 17:21
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants