Generalize area type in check function #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Generalize area type type in check function so we can check for the european model that a given list of countries are in the grid.
What the code is doing
Replace hard coded
state
by thegrid.model_immutables.zones["diivision"]
string that gives the division type (state or country so far) for a grid modelTesting
Existing unit tests
Where to look
Look at the
_check_areas_are_in_grid_and_format
functions. Other modifications are docstring improvementsUsage Example/Visuals
N/A
Time estimate
2min