Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize area type in check function #702

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Generalize area type in check function #702

merged 1 commit into from
Nov 3, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Nov 3, 2022

Pull Request doc

Purpose

Generalize area type type in check function so we can check for the european model that a given list of countries are in the grid.

What the code is doing

Replace hard coded state by the grid.model_immutables.zones["diivision"] string that gives the division type (state or country so far) for a grid model

Testing

Existing unit tests

Where to look

Look at the _check_areas_are_in_grid_and_format functions. Other modifications are docstring improvements

Usage Example/Visuals

N/A

Time estimate

2min

@rouille rouille added the refactor Code that is being refactored label Nov 3, 2022
@rouille rouille self-assigned this Nov 3, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rouille rouille merged commit 35bd7d4 into develop Nov 3, 2022
@rouille rouille deleted the ben/area branch November 3, 2022 23:53
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code that is being refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants