Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change constants of grid models #694

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Change constants of grid models #694

merged 3 commits into from
Oct 24, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Oct 24, 2022

Pull Request doc

Purpose

Update constants of grid models. To be able to reproduce the previous scenarios with the usa_tamu model, the default value for pmin_as_share_of_pmax is set to 1 (i.e. Pmin is equal to the power output given in the profile each hour) for hydro. As discussed in other channels, the value for ror is set to 0 (fully curtailable) in the europe_tub model. Finally, PHS is added to the list of clean resources.

What the code is doing

Change some constants value and update a dictionary

Testing

Current unit tests

Where to look

It is pretty minimal. The changes has been discussed during meetings and chat conversations.

Usage Example/Visuals

N/A

Time estimate

5min

@rouille rouille self-assigned this Oct 24, 2022
@lanesmith
Copy link
Collaborator

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

@BainanXia
Copy link
Collaborator

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

I think so, good catch.

@rouille
Copy link
Collaborator Author

rouille commented Oct 24, 2022

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

I think so, good catch.

Sounds good. Just to let you know, hydro and PHS will be combined to inflow. See comments here.

@BainanXia
Copy link
Collaborator

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

I think so, good catch.

Sounds good. Just to let you know, hydro and PHS will be combined to inflow. See comments here.

Ah, it clearer.

@rouille rouille merged commit 7ab40ae into develop Oct 24, 2022
@rouille rouille deleted the ben/hydro branch October 24, 2022 20:47
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants