-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix roundtrip PyPSA -> PSD -> PyPSA #689
Conversation
@@ -7,6 +7,16 @@ | |||
from powersimdata.utility.helpers import _check_import | |||
|
|||
|
|||
def restore_original_columns(df, overwrite=[]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is minor: we might what to avoid immutable defaults for kwargs, i.e. overwrite=None
with the logic in the function if not overwrite: overwrite = []
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be taken care of after it is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This fixes the conversion for the roundtrip PyPSA -> PSD -> PyPSA.
Test it with
Missing points: