Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource name #681

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix resource name #681

merged 1 commit into from
Sep 16, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Sep 16, 2022

Pull Request doc

Purpose

Use PHS instead of phs as resource name.

What the code is doing

No code

Testing

Existing unit tests

Where to look

The modification takes place in the attributes of the EUResource class in the powersimdata.network.constants.resource module.

Usage Example/Visuals

PyPSA-Eur uses PHS (upper case) for pumped hydro storage as illustrated below:

>>> from powersimdata.network.europe_tub.model import TUB
>>> tub = TUB("Europe", reduction=1024)
Title: PyPSA-Eur: An Open Optimisation Model of the European Transmission System (Dataset)
Keywords: power system model, capacity expansion model, energy system model, electricity system model, python
Publication date: 2022-09-10
DOI: 10.5281/zenodo.6913032
Total size: 2075.6 MB

Link: https://zenodo.org/api/files/7528030f-2993-4f54-83e4-9fdd223b9ba5/networks.zip   size: 2075.6 MB
networks.zip is already downloaded correctly.
All files have been downloaded.
>>> tub.build()
>>> tub.network.storage_units["carrier"].unique()
array(['hydro', 'PHS'], dtype=object)

Time estimate

1min

@rouille rouille added the bug Something isn't working label Sep 16, 2022
@rouille rouille self-assigned this Sep 16, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@rouille rouille merged commit c1f5830 into develop Sep 16, 2022
@rouille rouille deleted the ben/phs branch September 16, 2022 18:45
@rouille rouille changed the title Fix resource name resource name Fix resource name Sep 19, 2022
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants