Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update import statement #676

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix: update import statement #676

merged 1 commit into from
Sep 6, 2022

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Sep 6, 2022

Pull Request doc

Purpose

Import from the correct module. This might succeed at runtime due to the function already having been imported, but that's not reliable.

Time estimate

10 sec

@jenhagg jenhagg self-assigned this Sep 6, 2022
@jenhagg jenhagg requested review from BainanXia and rouille September 6, 2022 19:56
rouille
rouille approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jenhagg jenhagg merged commit b402bd6 into develop Sep 6, 2022
@jenhagg jenhagg deleted the jen/move branch September 6, 2022 20:00
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouille rouille rouille approved these changes

@BainanXia BainanXia BainanXia approved these changes

Assignees

@jenhagg jenhagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenhagg @rouille @BainanXia