Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment list of exported methods #664

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Augment list of exported methods #664

merged 1 commit into from
Aug 5, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Aug 4, 2022

Pull Request doc

Purpose

Export the get_profile and get_onshore_wind methods.

What the code is doing

Add the get_profile and get_onshore_wind methods to the list of exported_methods in the Ready class.

Testing

Current unit tests.

Where to look

In the powersimdata.scenario.ready module.

Usage Example/Visuals

N/A

Time estimate

2min

@rouille rouille self-assigned this Aug 4, 2022
@rouille rouille changed the title feat: augment list of exported methods Augment list of exported methods Aug 4, 2022
@jenhagg
Copy link
Collaborator

jenhagg commented Aug 4, 2022

Wonder if we'd want to remove the specific profile methods eventually (e.g. get_solar)?

@rouille
Copy link
Collaborator Author

rouille commented Aug 4, 2022

Wonder if we'd want to remove the specific profile methods eventually (e.g. get_solar)?

I am working on that in a different branch. I believe we could keep get_hydro, get_wind and get_solar since these methods returns the full profile and are not model specific. We should remove the get_onshore_wind and get_offshore_wind

@rouille rouille merged commit 4102634 into develop Aug 5, 2022
@rouille rouille deleted the ben/export branch August 5, 2022 02:40
@jenhagg jenhagg mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants