Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace "energy_price" by "energy_value" in storage template #663

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

BainanXia
Copy link
Collaborator

Pull Request doc

Purpose

Change a key word in storage template to make it consistent with elsewhere, replace "energy_price" by "energy_value".

Close #662

What the code is doing

Replace "energy_price" by "energy_value" in storage_template and rerun scenario_and_grid_cheatsheet.ipynb to reflect the change with the latest UI.

Testing

The demo notebook prints the updated key word.

Where to look

powersimdata/input/abstract_grid.py
powersimdata/scenario/demo/scenario_and_grid_cheatsheet.ipynb

Usage Example/Visuals

See scenario_and_grid_cheatsheet.ipynb

Time estimate

5 min

@BainanXia BainanXia self-assigned this Aug 1, 2022
@BainanXia BainanXia added the bug Something isn't working label Aug 1, 2022
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@BainanXia BainanXia merged commit 7d22a66 into develop Aug 1, 2022
@BainanXia BainanXia deleted the bainan/fix_energy_price branch August 1, 2022 16:50
@jenhagg jenhagg mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage key "energy value" inconsistent across modules
2 participants