Fix bugs in the Analyze class affecting demand flexibility #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
changed the title
jenhagg
reviewed
Jul 27, 2022
jenhagg
approved these changes
Jul 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Fix bugs in
Analyzeclass and update docstring of theOutputDataclassWhat the code is doing
Unindent the
get_load_shift_upandget_load_shift_dnmethods that were declared within theget_load_shedmethodsTesting
Existing unit tests
Where to look
Changes touch the
Analyzeclass. A docstring is updated in theOutputDataclassUsage Example/Visuals
N/A
Time estimate
2 min