Reorganize grid related modules and objects #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenhagg
approved these changes
Jun 8, 2022
| import pandas as pd | ||
|
|
||
|
|
||
| def add_column_to_data_frame(data_frame, column_dict): |
There was a problem hiding this comment.
Just looking through (and this is really just a stupid side-comment), there is the nice pandas version assign for that purpose
df = df.assign(**column_dict)might be helpful for future implementations
There was a problem hiding this comment.
Should I get rid of the add_column_to_data_frame function and used assign when needed?
merrielle
approved these changes
Jun 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Move and rename modules/classes/functions/tests related to grid creation from different sources and engines. The purpose is to make it clear where the data come from. To illustrate, we had a
powersimdata.input.scenario_gridmodule for reading the grid.mat file created by REISE/REISE.jl. In the future we will likely have CEM scenarios ran with PyPSA and the grid will be converted differently. For this reason the currentscenario_gridmodule is renamedreise_to_grid.Please propose other names/location ideas if you have some in mind.
What the code is doing
No new code. Modules /classes/functions/tests have been renamed and relocated.
Testing
Run existing tests
Where to look
In the new
powersimdata.input.converterandpowersimdata.input.exportermodulesUsage Example/Visuals
N/A
Time estimate
It should be short.