Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPSA exporter #649

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix PyPSA exporter #649

merged 1 commit into from
Jun 7, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jun 7, 2022

Pull Request doc

Purpose

Add missing rename value when converting a Grid object to a Network object. I forgot to include it when I updated the export_to_pypsa function from changes made in #608. As a result, the c1 column will not be renamed to marginal cost as expected by PyPSA

What the code is doing

N/A

Testing

I found the bug in the ben/import branch when trying to convert back to a Grid object a Network object previously created from a Grid object.

Where to look

You can compare what is done in #608 (see here)

Usage Example/Visuals

N/A

Time estimate

2min

@rouille rouille added the bug Something isn't working label Jun 7, 2022
@rouille rouille self-assigned this Jun 7, 2022
@rouille rouille changed the title fix: add missing rename in data structure Fix PyPSA exporter Jun 7, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. I remember we had the discussion that we would linearize the quadratic cost curve to calculate the marginal cost instead of taking c1 directly and we should rename it accordingly.

@rouille rouille merged commit ad072df into develop Jun 7, 2022
@rouille rouille deleted the ben/grid2pypsa branch June 7, 2022 23:05
@jenhagg jenhagg mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants