Grid clean up #648
Merged
Grid clean up #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BainanXia
approved these changes
Jun 5, 2022
jenhagg
reviewed
Jun 6, 2022
powersimdata/input/scenario_grid.py
Outdated
| @@ -318,6 +318,11 @@ def add_information_to_model(grid): | |||
|
|
|||
|
|
|||
| def reindex_model(grid): | |||
| """Reindex bus id columns. | |||
|
|
|||
| :param powersimdata.input.ScenarioGrid grid: grid | |||
There was a problem hiding this comment.
Think it should be powersimdata.input.scenario_grid.ScenarioGrid
jenhagg
approved these changes
Jun 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Clean up the grid related modules
What the code is doing
CSVReaderclasscsv_to_data_framefunction and rename itTesting
Run existing unit tests
Where to look
The
AbstractGridand theCSVReaderclassesUsage Example/Visuals
N/A
Time estimate
5min