Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid model handling #646

Merged
merged 34 commits into from
Jun 5, 2022
Merged

Grid model handling #646

merged 34 commits into from
Jun 5, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jun 3, 2022

Pull Request doc

Purpose

Merge hifld feature branch into develop. The goal was to handle different grid models enclosed in different data format and covering different region of the globe.

What the code is doing

All the code in the hifld branch has been reviewed already in #622, #627, #628, #631, #635 and #644.

Testing

  • Existing unit tests
  • New unit tests
  • End-to-end simulation, i.e., preparing a scenario, running it, loading it again and getting the Grid for Texas, USA, and Texas_Western before merging Refactor Grid object #628

Where to look

This feature branch touched a lot of module.

Usage Example/Visuals

N/A

Time estimate

5min

rouille and others added 30 commits June 3, 2022 13:36
Factor out constants of HIFLD and TAMU models
@rouille rouille self-assigned this Jun 3, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@jenhagg jenhagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rouille rouille merged commit a55e278 into develop Jun 5, 2022
@rouille rouille deleted the hifld branch June 5, 2022 05:18
@jenhagg jenhagg mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants