Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hifld from list of supported model #644

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jun 1, 2022

Pull Request doc

Purpose

Remove hifld from list of supported models since we will likely merge the hifld branch into develop before we have the HIFLD grid model ready.

What the code is doing

If a user tries to instantiate the Grid class with the source parameter set to hifld a ValueError will be raised. Also, the set_grid method of the Create class will throw the same error.

Testing

>>> from powersimdata import Grid
>>> g = Grid("ERCOT", source="hifld")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/brdo/CEM/PowerSimData/powersimdata/input/grid.py", line 35, in __init__
    raise ValueError(
ValueError: Source must be one of usa_tamu or the path to a .mat file that represents a grid 

Where to look

The powersimdata.input.grid module

Usage Example/Visuals

N/A

Time estimate

2min

@rouille rouille self-assigned this Jun 1, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

Base automatically changed from ben/builder to hifld June 2, 2022 19:40
@rouille rouille merged commit eb8888f into hifld Jun 3, 2022
@rouille rouille deleted the ben/unsupport branch June 3, 2022 19:05
@rouille rouille mentioned this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants