Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save correct data to case_storage.mat #637

Merged
merged 1 commit into from
May 20, 2022
Merged

fix: save correct data to case_storage.mat #637

merged 1 commit into from
May 20, 2022

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented May 20, 2022

Pull Request doc

Purpose

Fix obvious typo affecting scenarios that include storage in the change table.

What the code is doing

Save the right content to the mat file.

Testing

Ran it in docker.

Time estimate

1 min

@jenhagg jenhagg self-assigned this May 20, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch.

@jenhagg jenhagg merged commit eefa3c5 into develop May 20, 2022
@jenhagg jenhagg deleted the jh/storage branch May 20, 2022 21:32
@jenhagg jenhagg added the bug Something isn't working label May 20, 2022
@danielolsen
Copy link
Contributor

Aha! I think I see what's going on here. In REISE.jl, we have a try/catch around the whole process of loading the file as well as loading some of the data within the file (at certain locations), so we were successfully reading the file but then generating and catching an error when the right information wasn't in the right place, and telling the user that the file itself isn't there: https://github.com/Breakthrough-Energy/REISE.jl/blob/0ab4ad2430b26bf0e2288f4d882beb5b9c2f523b/src/read.jl#L80

@jenhagg jenhagg mentioned this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants