Create abstract grid class for model enclosed in CSV files #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielolsen
reviewed
May 3, 2022
danielolsen
approved these changes
May 3, 2022
jenhagg
approved these changes
May 3, 2022
BainanXia
approved these changes
May 3, 2022
rouille
changed the title
rouille
added a commit
that referenced
this pull request
May 25, 2022
rouille
added a commit
that referenced
this pull request
May 31, 2022
rouille
added a commit
that referenced
this pull request
Jun 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Create an abstract grid class for grid models that enclosed in CSVs files. In the future, some grid models will be stored in other forms so it is important to make the distinction
What the code is doing
Create a new class dedicated to the reading of CSV grid models (
AbstractGridCSV) that inherits from a higher levelAbstractGridclassTesting
Run
toxsuccessfullyWhere to look
The
powersimdata.input.abstract_gridmodule encloses the classes.Usage Example/Visuals
N/A
Time estimate
5min