fix: avoid Exception when calling get_load_shed on a Scenario without load shed #624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Fix a bug, where calling
Scenario.get_load_shed()
on a Scenario without any load shed throws an Exception.This bug seems to have been introduced in commit
5665083
within #475.What the code is doing
Since
output_dir
is a tuple of strings, rather than a single string, we need to unpack it before feeding toos.path.join
.Testing
The same example above no longer throws an Exception.
Time estimate
5 minutes.