Split input_data into separate modules #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
Apr 11, 2022
rouille
reviewed
Apr 11, 2022
rouille
reviewed
Apr 11, 2022
rouille
reviewed
Apr 13, 2022
| @staticmethod | ||
| def get_file_components(scenario_info, field_name): | ||
| """Get the file name and relative path for either ct or grid. | ||
| def _get_file_path(self, scenario_info, field_name): |
There was a problem hiding this comment.
I think we can still use the staticmethod decorator here
There was a problem hiding this comment.
Think that would require moving self._file_extension outside the class. Feels simpler to have it be an instance method since I'm not 100% sure about static methods and inheritance (though it does seem to work similarly).
There was a problem hiding this comment.
Oops, I did not see that the _file_extension attribute was used
There was a problem hiding this comment.
AFAIK, static methods will work with inheritance, as well as class methods, while the latter will be more convenient when dealing with multilayer inheritance.
jenhagg
force-pushed
the
jon/input_data
branch
2 times, most recently
from
d0f5ac3 to
6e0818d
Compare
rouille
reviewed
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to add support for loading electrification profiles and determining the versions, but they will likely be organized differently than the existing profiles. So rather than add more conditional logic to InputData it seems like a good time to do this.
What the code is doing
Move logic to get profiles into the
ProfileInputclass. Most of this PR is renaming accordingly. The shared logic is inInputBasewhich also defines the "abstract" methods that are filled in by subclasses.If we like this design (it's not perfect, but hopefully better than before) I will follow the pattern for electrification profiles, which would probably just be another subclass. I'm also on the fence about whether to separate the demand flexibility profiles but that could be another follow up PR.
Testing
Other than tox, I ran a simulation in the container environment which completed successfully.
Time estimate
20 min