fix: make start_date and end_date applicable to boundaries #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Fix a bug when creating scenarios,
start_dateandend_datecan be set at the boundaries of the time range, i.e.start_datecan't be2016-12-31 23:00:00andend_datecan't be2016-01-01 00:00:00. This shouldn't be the case given our time range is inclusive, which will prevent users from running 1h scenarios for the first or the last hour of the year.What the code is doing
A hot fix on the input checks.
Testing
An integration test of running a 1h USA scenario is successfully conducted.
Where to look
powersimdata/scenario/create.pyUsage Example/Visuals
Before it gives value error:
Now it runs successfully
Time estimate
2 min