fix: avoid storage mat with empty change table #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
rouille
force-pushed
the
empty_storage_mat_fix
branch
from
04f6d8d to
8860ede
Compare
ghost
self-assigned this
kasparm
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where if there is no change table specified, an empty case_storage.mat file will be created and sent to the server (Issue #60). This was because we were wiping the storage entry in the grid object only if a change table existed but did not contain storage entries.
We are fixing this by always keeping the storage dict in the grid object, and inspecting the length of grid.storage['gen'] to see if there is any storage present or not to determine whether or not to create and send a storage.mat file.