fix: make distribute_demand_from_zones_to_buses robust to zero-demand zone #605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
If there is a zone with zero demand (i.e. all
"Pd"
values are zero for buses in that zone),distribute_demand_from_zones_to_buses
will fail, sincepandas.pivot_table
will by default drop some rows/columns and we will end up with a matrix of a different size. This tweak fixes that.What the code is doing
By passing
dropna=False
, we ensure thatpivot_table
returns a matrix of a constant size, no matter whether there are zero-demand zones or not.Testing
Tested manually. Before:
After:
Time estimate
5 minutes.