Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export_data: hotfix column name #602

Merged

Conversation

FabianHofmann
Copy link
Contributor

Purpose

This PR fixes a typo in export_data.py.

What the code is doing

Exporting the ramp limit column for generators to pypsa

Time estimate

1 min

Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@rouille
Copy link
Collaborator

rouille commented Mar 14, 2022

Hi @FabianHofmann. Can you perform an interactive rebase to fix up these to commits and reword it following our git message template, i.e, fix: message. Thanks.

@FabianHofmann FabianHofmann force-pushed the pypsa-exporter-fix-ramp-column branch from 48da89f to abc42ac Compare March 14, 2022 15:53
@FabianHofmann
Copy link
Contributor Author

@rouille thanks for making me aware of the commit conventions. The commit(s) are renamed now. The branch was rebased before.

@rouille
Copy link
Collaborator

rouille commented Mar 14, 2022

@rouille thanks for making me aware of the commit conventions. The commit(s) are renamed now. The branch was rebased before.

Thanks! If you want to know more about it, you can check https://breakthrough-energy.github.io/docs/user/git_guide.html#commit-message

@danielolsen danielolsen merged commit 7d3dbdd into Breakthrough-Energy:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants