Use temp filesystem for profile test #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenhagg
force-pushed
the
jon/demand_flex
branch
2 times, most recently
from
5bbed0f to
46beb33
Compare
lanesmith
reviewed
Mar 2, 2022
lanesmith
approved these changes
Mar 2, 2022
lanesmith
pushed a commit
that referenced
this pull request
Mar 4, 2022
lanesmith
pushed a commit
that referenced
this pull request
Mar 9, 2022
lanesmith
pushed a commit
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
I wasn't sure how this would work so did some experimenting, made a few tweaks, etc. This makes it so the mocked
DataAccessinstance (or really, any instance) will use theself.local_fsattribute to get local profiles, instead of having that be hard coded to useLOCAL_DIR. In this case, the local_fs is aTempFSso it's completely isolated from existing files.What the code is doing
See above
Testing
tox
Time estimate
5-10 min