mock_input_data: fix eval computation for new pandas version #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielolsen
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
The lambda here is pretty cool! Tests pass:
- locally in an environment with
numexpr. - when the branch from Enable Export from Scenario/Grid to pypsa.Network #576 is rebased onto this one, in a docker environment that emulates the CI environment where the Enable Export from Scenario/Grid to pypsa.Network #576 tests had been failing.
jenhagg
approved these changes
Feb 24, 2022
BainanXia
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
With the up-to-date pandas version the eval string in
powersimdata/tests/mock_input_data.pyfails due to a chained call of the@accessor. This PR provides a fix for that the error.What the code is doing
Instead of the
evalcall, use a lambda function for the selection.Testing
It fixes the tests with the new pandas version.
Time estimate
3 min