Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data access integration tests #588

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Fix data access integration tests #588

merged 2 commits into from
Feb 14, 2022

Conversation

danielolsen
Copy link
Contributor

Pull Request doc

Purpose

Fix failing integration tests. This is a clean-up from #584.

What the code is doing

  • SSHDataAccess gets an exec_command method which passes the command through to the SSH filesystem.
  • Two obsolete tests are removed from the ScenarioListManager and ExecuteListManager test sets. @jon-hagg said 'they were testing fallback logic that moved from csv_store.py to the copy_from method in DataAccess, so that is tested elsewhere'.

Testing

pytest . passes all tests when connected to the VPN, and when not connected to the VPN the only test failure is test_setup_server_connection.

Time estimate

5 minutes to understand these changes, longer if you want to go back to #584 and trace the evolution of tests there.

@danielolsen danielolsen added the bug Something isn't working label Feb 14, 2022
@danielolsen danielolsen self-assigned this Feb 14, 2022
kasparm
kasparm approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.
Thanks for the fix!

@danielolsen danielolsen merged commit 5b1500e into develop Feb 14, 2022
@danielolsen danielolsen deleted the daniel/fix_data_access_integration_tests branch February 14, 2022 20:57
@jenhagg jenhagg mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasparm kasparm kasparm approved these changes

@BainanXia BainanXia BainanXia approved these changes

Assignees

@danielolsen danielolsen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielolsen @kasparm @BainanXia