fix: pass _Builder start and end date to TransformProfile #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Ensure that profiles of appropriate length are being returned in partial-year
Create-state Scenarios. This got broken during the refactor of #581, and must have been missed while we tested partial-yearAnalyze-state Scenarios.What the code is doing
Now that profile slicing is contained within
TransformProfile, with a dictionary of Scenario information passed to control the start & end timestamps to slice, we need to make sure that the_Builderobject passes this information to theTransformProfileinit.Testing
Manually ran the tests in
powersimdata/scenario/tests/test_create.pywhich aren't normally run (since they're markedintegration.Time estimate
5 minutes.