bug fixes for launcher and data_access test #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenhagg
approved these changes
Oct 22, 2021
…to fs according to PR #520
kasparm
force-pushed
the
kasparm/launch_bug_fix
branch
from
0631593 to
cdbaf2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing a few bugs
Testing
How did you test this change (unit/functional testing, manual testing, etc.)?
Run the tests using pytest in the root folder.
Run a scenario on the server with Gurobi.
Where to look
powersimdata/data_access/launcher.pypowersimdata/data_access/tests/test_data_acces.pyTime estimate
How long will it take for reviewers and observers to understand this code change?
5 - 30min
Depending if you are setup to run scenarios on the server with Gurobi.