fix: prevent max recursion error

[jenhagg]

Purpose

When a scenario is in the execute state and we try to create a new scenario object, there is a max recursion error. This happens because due to the following loop (rough outline):

scenario.__init__
execute.__init__
execute.refresh
launcher.__init__
scenario.scenario_id
scenario.__getattr__
self.state (in the process of being set)
scenario.__getattr__
self.state (in the process of being set)
scenario.__getattr__
etc

What the code is doing

Delay evaluation of scenario.scenario_id until after the objects are fully instantiated.

Testing

Loaded scenario 3898 which is in execute state:

• before: max recursion error
• after: loads successfully

Time estimate

Not sure

[kasparm]

Thanks for the fix!

[kasparm]

I will go ahead and run scenario 3898 and then delete it. Any other scenario in execute state can be used for testing if anybody wants to reproduce the bug.