feat: allow the user to remove lines, buses, plants, and DC lines #554

danielolsen · 2021-09-28T23:01:55Z

Purpose

~~Partial fulfilment of~~ Closes #423. Plants and DC lines can already be effectively removed by scaling them down to zero, this allows branches and buses to be removed as well. If we like the structure of the branch and bus removal, and want to enable full removal of plants, DC lines, storage, etc., then I can amend this PR to include those analogous methods as well.

What the code is doing

Within the ChangeTable class:

We add new methods remove_bus and remove_branch, which check that the elements to be removed are actually in the grid before adding to the change table dictionary. remove_bus has a check to ensure that a bus cannot be removed if there's at least one plant with non-zero capacity at it, and to implement this we modify _get_df_with_new_elements so that if we request the plant table, we apply any plant scaling.
We add a user notification method, to ensure that the user is aware if they've accidentally islanded some load buses. This will not break the simulation, but load shedding will be enabled which could slow simulation.

Within the TransformGrid class:

We interpret the "remove_bus" and "remove_branch" change table keys.

Testing

New unit tests added.

Time estimate

15-30 minutes.

rouille · 2021-09-29T13:24:01Z

powersimdata/input/change_table.py

+                    for subkey, subdict in self.ct.get(k, {}).items()
+                ]
+            )
+        )


you lost me here. What if modification is a single element, i.e., table is not plant? Won't modification_keys[1:] raise an error?

No, we'll just get an empty list:

>>> foo = ["a"] >>> foo[1:] []

The current implementation is clunky for sure. If table == "plant", then we want to reliably create a tuple that includes all plant additions and plant scaling information. If table != "plant", we should be creating a tuple as before, just with one new top-level string entry for "new_bus" or "new_branch" or whatever.

I am wondering if we should not, for readability, purpose have a modified_elements_tuple for plants (within if table == "plants" statement) and another one for the other (bus, branch, etc.)

I've refactored this a bit to try to make it a little clearer what's going on.

powersimdata/input/change_table.py

rouille · 2021-10-11T18:23:05Z

I guess at some point we should use the generators' type in the grid model (defined in powersimdata.network.[grid_model].constants.plants) and not redefined those in the change_table module:

_resources = (
    "coal",
    "dfo",
    "geothermal",
    "ng",
    "nuclear",
    "hydro",
    "solar",
    "wind",
    "wind_offshore",
    "biomass",
    "other",
)
_renewable_resource = {"hydro", "solar", "wind", "wind_offshore"}

Same in the TransformGrid class.

I wil take care of it in a follow up PR

powersimdata/input/change_table.py

rouille · 2021-10-11T18:28:41Z

Should we update the clear method to be able to remove the two keys introduced in this PR?

powersimdata/input/change_table.py

danielolsen · 2021-10-26T17:57:57Z

Should we update the clear method to be able to remove the two keys introduced in this PR?

Done.

rouille · 2021-10-26T19:20:53Z

Do you plan to remove the other objects (DC lines, plants, etc) in this PR?

danielolsen · 2021-10-26T19:46:23Z

Do you plan to remove the other objects (DC lines, plants, etc) in this PR?

Done.

rouille

LGTM. I think it will be nice to develop some checks to ensure that demand does not exceed generation and so forth.

powersimdata/input/change_table.py

BainanXia · 2021-10-26T20:28:20Z

powersimdata/input/change_table.py

+    def _check_for_islanded_load_buses(self):
+        """Identifies buses with non-zero demand, with no connected lines, and warns."""
+        bus = self._get_transformed_df("bus")
+        connected_buses = set().union(
+            *[
+                set(self.grid.branch["from_bus_id"]),
+                set(self.grid.branch["to_bus_id"]),
+                set(self.grid.dcline["from_bus_id"]),
+                set(self.grid.dcline["to_bus_id"]),
+            ]
+        )
+        load_buses = set(bus.query("Pd > 0").index)
+        diff = load_buses - connected_buses
+        if len(diff) > 0:
+            print(f"Warning: load buses connected to no lines exist: {sorted(diff)}")


This is a neat check. Following the same logic, do we want to _check_for_islanded_generation_buses, or a comprehensive check that covers all the potential disconnected issues when removing entries from the grid?

I think there are two levels of potential issues: branches or DC lines or plants that connect to non-existent buses will crash the simulation engine, but islanded load buses should be okay since the simulation engine will just shed the load and continue. That's why I had one check raise an exception, but the other just printed a warning.

Agree. Thinking a little further, here is my list of potential issues:

branches, DC lines, plants or storage that result in connecting to non-existent buses (error)

removing entries makes the resultant grid multiple connected components (isolated load/generation buses are special cases in this situation)

on each island, if load (we only know Pd instead of actual load anyways) > generation, it is okay since load shedding will take care of it (warning)

on each island, if sum(Pmin) > load, it will crash the engine, however, I'm not sure how to check this though (maybe also warning instead of error?).

Pmin issues are also tricky since we're re-setting some Pmins within REISE.jl, which PowerSimData doesn't know about. If we add generation spillage to REISE.jl that should take care of things I think, and make the big problem into a smaller once (since we'll eventually get to a feasible solution).

Will leave this thread open for future PRs.

BainanXia

Thanks!

danielolsen requested review from rouille, BainanXia, jenhagg and ahurli September 28, 2021 23:01

danielolsen self-assigned this Sep 28, 2021

danielolsen force-pushed the daniel/remove_line branch from 6845812 to 2d1cd87 Compare September 28, 2021 23:54

rouille reviewed Sep 29, 2021

View reviewed changes

jenhagg reviewed Sep 29, 2021

View reviewed changes

powersimdata/input/change_table.py Outdated Show resolved Hide resolved

rouille reviewed Oct 11, 2021

View reviewed changes

powersimdata/input/change_table.py Show resolved Hide resolved

rouille reviewed Oct 11, 2021

View reviewed changes

powersimdata/input/change_table.py Show resolved Hide resolved

danielolsen force-pushed the daniel/remove_line branch from 27e6a12 to d0abf3d Compare October 26, 2021 19:05

danielolsen force-pushed the daniel/remove_line branch from d0abf3d to 5989d5f Compare October 26, 2021 19:46

danielolsen force-pushed the daniel/remove_line branch from 5989d5f to 5b3b48d Compare October 26, 2021 19:50

rouille approved these changes Oct 26, 2021

View reviewed changes

BainanXia reviewed Oct 26, 2021

View reviewed changes

powersimdata/input/change_table.py Show resolved Hide resolved

BainanXia reviewed Oct 26, 2021

View reviewed changes

danielolsen force-pushed the daniel/remove_line branch from e1d6f82 to afe6366 Compare October 26, 2021 22:19

danielolsen changed the title ~~feat: allow the user to remove lines and buses~~ feat: allow the user to remove lines, buses, plants, and DC lines Oct 26, 2021

BainanXia approved these changes Oct 28, 2021

View reviewed changes

danielolsen added 3 commits October 29, 2021 14:42

feat: add ChangeTable methods to remove elements

0415ef4

feat: add element removal methods to TransformGrid

87e4369

test: add tests for ChangeTable/TransformGrid element removal

1bbd03c

danielolsen force-pushed the daniel/remove_line branch from afe6366 to 1bbd03c Compare October 29, 2021 21:42

danielolsen merged commit f9ef411 into develop Oct 29, 2021

danielolsen deleted the daniel/remove_line branch October 29, 2021 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow the user to remove lines, buses, plants, and DC lines #554

feat: allow the user to remove lines, buses, plants, and DC lines #554

danielolsen commented Sep 28, 2021 •

edited

Loading

rouille Sep 29, 2021

danielolsen Sep 29, 2021

rouille Oct 11, 2021

danielolsen Oct 26, 2021

rouille commented Oct 11, 2021 •

edited

Loading

rouille commented Oct 11, 2021

danielolsen commented Oct 26, 2021

rouille commented Oct 26, 2021

danielolsen commented Oct 26, 2021

rouille left a comment

BainanXia Oct 26, 2021

danielolsen Oct 26, 2021

BainanXia Oct 26, 2021

danielolsen Oct 26, 2021

BainanXia Oct 28, 2021

BainanXia left a comment

feat: allow the user to remove lines, buses, plants, and DC lines #554

feat: allow the user to remove lines, buses, plants, and DC lines #554

Conversation

danielolsen commented Sep 28, 2021 • edited Loading

Purpose

What the code is doing

Testing

Time estimate

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rouille commented Oct 11, 2021 • edited Loading

rouille commented Oct 11, 2021

danielolsen commented Oct 26, 2021

rouille commented Oct 26, 2021

danielolsen commented Oct 26, 2021

rouille left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BainanXia left a comment

Choose a reason for hiding this comment

danielolsen commented Sep 28, 2021 •

edited

Loading

rouille commented Oct 11, 2021 •

edited

Loading