Remove psycopg2 dependency #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparm
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Reduce the installation overhead and avoid related errors due compilation, etc.
What the code is doing
We aren't using this package except in tests, and don't really need to be running those right now - keeping them around in case they are useful when we switch to sqlite or alternate data store. For now they are moved to a sql folder and we tell pytest to ignore anything in there. As a result, we can simplify the ci workflow to just use
pytest-local.Testing
Ran
tox -e pytest-localand also built the docs locally - as expected there is an error generating docs for modules that import psycopg2, but those are simply omitted, and the rest of the docs look fine.Time estimate
5 min