Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: combine workflow triggers #537

Merged
merged 1 commit into from
Sep 1, 2021
Merged

ci: combine workflow triggers #537

merged 1 commit into from
Sep 1, 2021

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Sep 1, 2021

Purpose

Use the generic workflow trigger action to kick off the docs build and docker build in the respective repositories. Related issue Breakthrough-Energy/plug#26

What the code is doing

Removed obsolete docker build action, replaced it, and the existing docs trigger, with the workflow-trigger action.

Testing

Tested the action manually

Time estimate

5 min

@jenhagg jenhagg self-assigned this Sep 1, 2021
@jenhagg jenhagg requested review from ahurli and rouille September 1, 2021 18:32
@jenhagg
Copy link
Collaborator Author

jenhagg commented Sep 1, 2021

Note: I've manually disabled the 'Publish docker image' workflow and removed the CR_PAT secret ahead of time, since they will be obsolete when this is merged.

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@jenhagg jenhagg added the refactor Code that is being refactored label Sep 1, 2021
@jenhagg jenhagg force-pushed the jon/workflow-trigger branch from 614d6ed to b2ef9d5 Compare September 1, 2021 20:39
@jenhagg jenhagg merged commit 8d75e47 into develop Sep 1, 2021
@jenhagg jenhagg deleted the jon/workflow-trigger branch September 1, 2021 20:54
rouille pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code that is being refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants