feat: make build_supply_curve work with any gen_type combinations #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Extend the capability of
build_supply_curve. Previously, it only works with single generation type. Now it works with any combinations of generation types.The closes PR #532
What the code is doing
The input parameter
gen_typecan be string or any iterables now, which will be used to filter generators from the data frame. A legend is added to explicitly show which generator types are considered in the plot.Testing
Manually
Where to look
/powersimdata/design/generation/cost_curves.pyUsage Example/Visuals
Time estimate
5 min