Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix yaml and add codecov badge #509

Merged
merged 1 commit into from
Jun 25, 2021
Merged

ci: fix yaml and add codecov badge #509

merged 1 commit into from
Jun 25, 2021

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Jun 24, 2021

Purpose

Apparently we can't use environment variables in jobs.<job_id>.name, so this fixes that. Also added the badge.

Testing

Pushed branch with workflow enabled, to check that the yaml is considered valid.

Time estimate

1 min

@jenhagg jenhagg requested a review from rouille June 24, 2021 22:43
@jenhagg jenhagg self-assigned this Jun 24, 2021
@@ -1,6 +1,7 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an empty line before the logo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok? Doesn't look like it changes the appearance

@@ -1,6 +1,7 @@

![logo](https://raw.githubusercontent.com/Breakthrough-Energy/docs/master/source/_static/img/BE_Sciences_RGB_Horizontal_Color.svg)

[![codecov](https://codecov.io/gh/Breakthrough-Energy/PowerSimData/branch/develop/graph/badge.svg?token=5A20TCV5XL)](https://codecov.io/gh/Breakthrough-Energy/PowerSimData)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jenhagg jenhagg merged commit 68ccd7c into develop Jun 25, 2021
@jenhagg jenhagg deleted the jon/codecov branch June 25, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants