-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add compare module, move Grid/Scenario check functions from PostREISE to PowerSimData #507
Conversation
6199c96
to
1876932
Compare
04b0640
to
a808ad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice. Thanks.
Per discussion at Breakthrough-Energy/PostREISE#310, we probably also want to move |
Your call |
a808ad6
to
c744006
Compare
c744006
to
b46cae3
Compare
Pull Request doc
Purpose
powersimdata.design.compare
, to consolidate code which compares Grid data tables.What the code is doing
powersimdata.design.compare
gets comparison logic that had been performed elsewhere in PowerSimData or PostREISE.powersimdata.design.investment
uses the newly consolidated comparison logic.powersimdata.input.check
andpowersimdata.scenario.check
get the Grid and Scenario check functions (with associated tests).Testing
Existing unit tests still pass. The existing comparison logic in PowerSimData was untested, but now has a path to getting tests, since it is separated from the broader investment cost calculations.
Where to look
The only real new code is in
powersimdata.design.compare.generation
, since it is more robust than what we had before incalculate_gen_inv_costs
. Everything else is just moved from elsewhere, with references updated.Time estimate
15-30 minutes.