Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate column constants in const.py #497

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

danielolsen
Copy link
Contributor

Pull Request doc

Purpose

Consolidate column names/types in one place, to reduce duplicate information and potential headaches when making changes.

What the code is doing

No code. Only constants being moved around.

Testing

All tests still pass.

Time estimate

5 minutes.

@danielolsen danielolsen added the refactor Code that is being refactored label Jun 8, 2021
@danielolsen danielolsen self-assigned this Jun 8, 2021
@danielolsen danielolsen changed the title Daniel/column constants refactor: consolidate column constants in const.py Jun 8, 2021
@danielolsen danielolsen force-pushed the daniel/column_constants branch from facae36 to b2e96ba Compare June 8, 2021 19:05
@BainanXia
Copy link
Collaborator

In this case, we don't need column_name_provider or column_type_provider any more in scenario_grid.py, do we?

@danielolsen
Copy link
Contributor Author

In this case, we don't need column_name_provider or column_type_provider any more in scenario_grid.py, do we?

There are still some uses of these that would need to be refactored:

col_name = column_name_provider()[name]

@BainanXia
Copy link
Collaborator

In this case, we don't need column_name_provider or column_type_provider any more in scenario_grid.py, do we?

There are still some uses of these that would need to be refactored:

col_name = column_name_provider()[name]

Whoops, you are right.

Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.

@danielolsen danielolsen merged commit 7b2af6a into develop Jun 9, 2021
@danielolsen danielolsen deleted the daniel/column_constants branch June 9, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code that is being refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants