-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: consolidate column constants in const.py #497
Conversation
facae36
to
b2e96ba
Compare
In this case, we don't need |
There are still some uses of these that would need to be refactored:
|
Whoops, you are right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense.
Pull Request doc
Purpose
Consolidate column names/types in one place, to reduce duplicate information and potential headaches when making changes.
What the code is doing
No code. Only constants being moved around.
Testing
All tests still pass.
Time estimate
5 minutes.