refactor: set grid_model property on grid #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
Jun 3, 2021
| @@ -176,7 +176,7 @@ def get_branches_by_area(grid, area_names, method="either"): | |||
|
|
|||
| branch = grid.branch | |||
| selected_branches = set() | |||
| grid_model = grid.get_grid_model() | |||
| grid_model = grid.grid_model | |||
| for a in area_names: | |||
| load_zone_names = area_to_loadzone(grid_model, a) | |||
There was a problem hiding this comment.
Can we use grid.grid_model here and remove grid_model = grid.grid_model since there is the only place where it is used
rouille
reviewed
Jun 3, 2021
| ng_plant_id = _select_plant_id("ng") | ||
| coal_plant_id = _select_plant_id("coal") | ||
| dfo_plant_id = _select_plant_id("dfo") | ||
| hydro_plant_id = _select_plant_id("hydro") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the property to grid and mock grid classes as it's commonly used and set at init time.
What the code is doing
Simplify the grid constructor by adding
self.grid_modelas an instance variable - no need to try/catch to setModelImmutables. Also set the property inMockGridsince it's already available.Testing
Existing unit tests
Time estimate
5 min