Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to export profiles #486

Merged
merged 2 commits into from
May 21, 2021
Merged

Add function to export profiles #486

merged 2 commits into from
May 21, 2021

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented May 21, 2021

Purpose

Address #482

What the code is doing

Define export_scaled_profile function which can be called given a profile kind/version, grid, change table, and destination path. We now call this function from SimulationInput.prepare_profile, but it could be called independent of a scenario.

Testing

Prepared a scenario in a container with a change table and it worked as expected.

Time estimate

10 min

@jenhagg jenhagg self-assigned this May 21, 2021
@jenhagg jenhagg added the refactor Code that is being refactored label May 21, 2021
@jenhagg jenhagg added this to the Welcome interns! milestone May 21, 2021
@jenhagg jenhagg linked an issue May 21, 2021 that may be closed by this pull request
1 task
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the clean up, object is no longer needed with Python 3.0+

Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation, thanks.

@rouille
Copy link
Collaborator

rouille commented May 21, 2021

Kind of wondering, if it would make sense to have an export_data module in powersimdata.input that will gather the function @jon-hagg just implemented and the export_case_mat function.

@BainanXia
Copy link
Collaborator

Kind of wondering, if it would make sense to have an export_data module in powersimdata.input that will gather the function @jon-hagg just implemented and the export_case_mat function.

That would definitely be more explicit from the user's perspective.

@jenhagg jenhagg force-pushed the jon/export_profiles branch from 475b1b5 to 13b4357 Compare May 21, 2021 17:28
@jenhagg jenhagg merged commit ad52656 into develop May 21, 2021
@jenhagg jenhagg deleted the jon/export_profiles branch May 21, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code that is being refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add function to create profiles without uploading to the server
4 participants