fix: create copy of bus table before modifying within get_bus_demand function #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
When performing the
get_bus_demand
function, avoid modifying the bus table of the Grid that is passed as input. This is not a problem when we callscenario.get_bus_demand()
on a Scenario in Analyze state, since that method passes a fresh copy of the grid so the grid associated with the scenario doesn't change, but it's still an unintuitive behavior in case anyone uses the lower-level function.Testing
Before:
After:
Time estimate
2 minutes.