Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badges to README #478

Merged
merged 1 commit into from
May 13, 2021
Merged

Add badges to README #478

merged 1 commit into from
May 13, 2021

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented May 12, 2021 •
edited
Loading

Pull Request doc

Purpose

Add badges for the sake of adding badges.

What the code is doing

N/A

Testing

N/A

Where to look

  • Made with Python
  • Code of conduct
  • Contributors
  • Commit activity
  • Last commit
  • Pull Requests open

Usage Example/Visuals

The badges are displayed here

Time estimate

N/A

@rouille rouille added the documentation Documentation related to package label May 12, 2021
@rouille rouille self-assigned this May 12, 2021
kasparm
kasparm approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

This is like nicely wrapping a present.

jenhagg
jenhagg approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@jenhagg jenhagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of the style: prefix

BainanXia
BainanXia approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @kasparm said, Indeed.

@rouille
Copy link
Collaborator Author

rouille commented May 12, 2021

Should I add this one?

@rouille rouille merged commit f01e4dc into develop May 13, 2021
@rouille rouille deleted the ben/badge branch May 13, 2021 15:12
@rouille rouille mentioned this pull request May 13, 2021
Merged
@danielolsen danielolsen mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasparm kasparm kasparm approved these changes

@BainanXia BainanXia BainanXia approved these changes

@jenhagg jenhagg jenhagg approved these changes

@danielolsen danielolsen Awaiting requested review from danielolsen

@ahurli ahurli Awaiting requested review from ahurli

Assignees

@rouille rouille

Labels
documentation Documentation related to package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rouille @kasparm @BainanXia @jenhagg