Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump cryptography from 3.3.1 to 3.3.2 #393

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 10, 2021

Bumps cryptography from 3.3.1 to 3.3.2.

Changelog

Sourced from cryptography's changelog.

3.3.2 - 2021-02-07


* **SECURITY ISSUE:** Fixed a bug where certain sequences of ``update()`` calls
  when symmetrically encrypting very large payloads (>2GB) could result in an
  integer overflow, leading to buffer overflows. *CVE-2020-36242*

.. _v3-3-1:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 10, 2021
@jenhagg
Copy link
Collaborator

jenhagg commented Feb 13, 2021

I'm able to download scenarios using this branch on mac os, should we merge or does anyone else want to try?

@rouille
Copy link
Collaborator

rouille commented Feb 13, 2021

I'm able to download scenarios using this branch on mac os, should we merge or does anyone else want to try?

If you can download them it means that you can establish the connection with the server using the RSA key so I would say it is fine. The question I have is should we update the Pipfile in this PR too? Only the lockfile is updated here.

@jenhagg
Copy link
Collaborator

jenhagg commented Feb 13, 2021

I'd say it's fine to only update the lock file, since cryptography is not a top level dependency - it's only added to the lock file because other packages (e.g. paramiko) requires it. So we should let the resolver figure out what version we need.

@rouille
Copy link
Collaborator

rouille commented Feb 13, 2021

I forgot about that. At some we had cryptography in our requirements file because we wanted the version to be fixed but it was along time ago.

@jenhagg
Copy link
Collaborator

jenhagg commented Feb 16, 2021

Apparently dependabot tried to create similar PRs in Pre/PostREISE since the lock files there contain powersimdata deps as well, but it didn't know how to handle the relative path we use, e.g. here. Could do manually if we want to, but don't think it's that urgent.

@danielolsen danielolsen self-requested a review February 16, 2021 22:55
Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this works to both get data from previous scenarios and to launch new ones.

@rouille
Copy link
Collaborator

rouille commented Feb 17, 2021

Who will merge that. Should I do it?

@danielolsen
Copy link
Contributor

Who will merge that. Should I do it?

Thank you for volunteering.

@rouille
Copy link
Collaborator

rouille commented Feb 17, 2021

Who will merge that. Should I do it?

Thank you for volunteering.

I am not responsible if it breaks everything

@rouille rouille merged commit 5cc57d9 into develop Feb 17, 2021
@rouille rouille deleted the dependabot/pip/cryptography-3.3.2 branch February 17, 2021 22:59
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants