doc: update investment cost README for current calculations #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
Jan 29, 2021
rouille
reviewed
Jan 29, 2021
rouille
reviewed
Jan 29, 2021
danielolsen
force-pushed
the
daniel/investment_readme
branch
from
91307d8 to
390e71f
Compare
rouille
reviewed
Jan 29, 2021
|
|
||
| **bus_to_neem_reg**: maps bus locations to NEEM regions. Used in `write_bus_neem_map` and (if there are errors in the mapping file produced in `write_bus_neem_map`), this function is also used in `_calculate_ac_inv_costs`. | ||
| `bus_to_neem_reg`: maps bus locations to NEEM regions. Used in `write_bus_neem_map` and (if there are errors in the mapping file produced in `write_bus_neem_map`), this function is also used in `_calculate_ac_inv_costs`. |
There was a problem hiding this comment.
Not sure I understand the above sentence. I read taht the bus_to_neem_reg function is used in _calculate_ac_inv_costs only if there are errors in the mapping file.
There was a problem hiding this comment.
The wording is a bit strange. It is used within write_bus_neem_map to create a mapping file, and if a cached mapping file does not map all buses successfully at runtime then it is used as a part of _calculate_ac_inv_costs.
rouille
reviewed
Jan 29, 2021
rouille
reviewed
Jan 29, 2021
rouille
reviewed
Jan 29, 2021
rouille
reviewed
Jan 29, 2021
rouille
reviewed
Jan 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update the README in the investment cost folder (this got missed in #297).
What the code is doing
No code.
Time estimate
15 minutes.