Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix error when deleting data, and handle clearing local data correctly.
What the code is doing
The
self.path_config
attribute needs to be set in the base class since we don't actually call theDelete
constructor. Also, data is now cached in the same tree structure as the server, so changed the glob to match that.I removed the implementation in
DataAccess
since that will fail when glob matches are directories instead of files, and didn't feel a strong need for it but I can put it back if people are using it.Testing
Shell session testing the glob change
Separate session testing the delete state:
Time estimate
5 min