Specify grid model when creating scenario

[rouille]

Purpose

Set grid model during the building phase of a scenario (#84)

What the code is doing

A set_grid_model method in the Create class allows to set the grid model. If not called the grid_model key of the scenario_info dictionary is set to usa_tamu. When the create scenario method of the Create class is called the grid_model field (located between engine and runtime) in the *ScenarioList file will be set.

Testing

We will create/launch/extract a dummy scenario

Where to look

• The powersimdata.scenario.create module where the set_grid_model method can be called and the scenario_info dictionary is filled.
• The powersimdata.scenario.execute module where the Grid class is instantiated using the grid_model key of the scenario_info dictionary.

Time estimate

15min. It mirrors what we did to set the engine

Note

We will have before testing to add a new grid_model column to the *ScenarioList file and set usa_tamu as value for all existing scenario

[BainanXia]

This is clean.

[danielolsen]

While we're updating _Builder can we also set the default interval to be "24H" rather than "144H"?

[rouille]

I had to do further modifications after realizing that the source parameter of the Grid class was needed in the Builder class. Let me know what you think of the changes and if it can improved. It is kind of ugly.

[danielolsen]

It is kind of ugly.

You are right. But I think it will work. I won't have time to think about refactoring until next week.

[rouille]

It is kind of ugly.

You are right. But I think it will work. I won't have time to think about refactoring until next week.

There is no rush, there is only one grid as of now. We can think about it for some time. Perhaps @jon-hagg can help us finding a better design in the coming weeks.

[BainanXia]

It is kind of ugly.

You are right. But I think it will work. I won't have time to think about refactoring until next week.

There is no rush, there is only one grid as of now. We can think about it for some time. Perhaps @jon-hagg can help us finding a better design in the coming weeks.

I would suggest making the current builders for concrete classes (Texas, Western, etc) available for usa_tamu model only, since other models in the future may not have the same split as the current model does. Maybe we could have three layer of builder classes: 1) Abstract builder 2) Model builder inherit the abstract builder 3) Sub-network builder inherit model builder if any.

[danielolsen]

Do we even really need different Builder sub-classes for the different interconnects? All object behave identically, with the only difference being their name and interconnect attributes (or name, grid_model, and interconnect after this update).

[BainanXia]

Do we even really need different Builder sub-classes for the different interconnects? All object behave identically, with the only difference being their name and interconnect attributes (or name, grid_model, and interconnect after this update).

It's been a while. I forgot the reason how we came up with the current design. @rouille must have a better idea on this.

[rouille]

I close this since we will tackle this in #344