fix: use UNIX path #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparm
reviewed
Aug 7, 2019
| @@ -120,6 +121,8 @@ def _upload_change_table(self): | |||
| print("--> Uploading change table to server") | |||
| file_name = self._scenario_info['id'] + '_ct.pkl' | |||
| upload(self._ssh, file_name, const.LOCAL_DIR, const.INPUT_DIR) | |||
| print("--> Deleting change table on local machine") | |||
There was a problem hiding this comment.
It is not a fix. It deletes the change table after uploading all the scenario data inputs to the server. The fix was to delete the scaled profile from the local machine. Deleting the change table is not necessary but it is cleaner since the other inputs are deleted.
There was a problem hiding this comment.
Got it. So that is an additional change not related to the OS specific path issue.
There was a problem hiding this comment.
Yes. I did not feel like creating a new PR for this one line of code.
kasparm
approved these changes
Aug 7, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set path to POSIX pathname every time a UNIX command is called from local machine to run on server. This should resolve the issue users having a Windows OS encounters when communicating with the server (Linux OS).