Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribution file #319

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Attribution file #319

merged 1 commit into from
Oct 20, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Oct 20, 2020

Purpose

Write attribution file. Only dataset in the develop branch are referenced.

Where to look

In the ATTRIBUTION.md file

Time estimate

5min

@rouille rouille added the documentation Documentation related to package label Oct 20, 2020
@rouille rouille added this to the spiders milestone Oct 20, 2020
kasparm
kasparm approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks

BainanXia
BainanXia approved these changes Oct 20, 2020
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good that we have a paper published so that we could do a one pointer reference. This is nice.

@rouille rouille merged commit e56fa73 into develop Oct 20, 2020
@rouille rouille deleted the ben/attribution branch October 20, 2020 20:20
@ahurli ahurli mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasparm kasparm kasparm approved these changes

@BainanXia BainanXia BainanXia approved these changes

@danielolsen danielolsen Awaiting requested review from danielolsen

Assignees

@danielolsen danielolsen

@kasparm kasparm

@rouille rouille

@BainanXia BainanXia

Labels
documentation Documentation related to package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rouille @kasparm @BainanXia @danielolsen