-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate transformer costs based on per-MW values #312
Conversation
The transformer cost calculation method has been updated to use the regional multipliers for AC lines (using the highest voltage from either the from_bus or to_bus side of the transformer). The code is ugly, but the logic works for both the unit tests as well as large upgrade scenarios. |
5fba797
to
d66f26e
Compare
86de56d
to
3ea22a8
Compare
d66f26e
to
3f4f546
Compare
6ee0237
to
bfd100d
Compare
81000c3
to
6ce9719
Compare
bfd100d
to
e1bd05b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the test.
e1bd05b
to
4e0eca4
Compare
Purpose
Address to-do-list item from #297: calculate transformer upgrade costs on a per-MW basis, rather than per-transformer.
What is the code doing
Real functionality updates are in
investment_costs.py
:select_kV
is removed (functionality rolled into the main body), since we don't use it for transformers anymore, just lines.Everything else is data, data locations, and test updates.
Time to review
15 minutes.