refactor: add mwmiles calculations to design.transmission module

[danielolsen]

Purpose

Moves analyses of scenario design (i.e., analyses that only work on the Grid or ChangeTable and do not require any results) from PostREISE to PowerSimData. See https://github.com/Breakthrough-Energy/RenewableEnergyProject/issues/307 and Breakthrough-Energy/PostREISE#162.

What is the code doing

There is no new code, only code from PostREISE being added (into the new powersimdata/design/transmission folder), renamed (powersimdata.design.transmission -> powersimdata.design.transmission.upgrade), or import corrections.

Validation

All tests pass.

Time to review

10 minutes.

[rouille]

Do you plan to create the generation folder in a different PR?

[danielolsen]

Do you plan to create the generation folder in a different PR?

Is it worth creating the folder now without putting anything in it? I was thinking I would wait until some generation design analysis code is ready for a PR.

[rouille]

Do you plan to create the generation folder in a different PR?

Is it worth creating the folder now without putting anything in it? I was thinking I would wait until some generation design analysis code is ready for a PR.

I thought there was already modules in powersimdata.design related to generation. We will create the folder later then.

[danielolsen]

I thought there was already modules in powersimdata.design related to generation. We will create the folder later then.

You are right, clean_capacity_scaling.py is definitely designing generation, as is mimic_grid.py (although in the future I would also like to mimic transmission as well, so maybe it is okay to keep here). Maybe I should create that folder now after all.

[rouille]

I thought there was already modules in powersimdata.design related to generation. We will create the folder later then.

You are right, clean_capacity_scaling.py is definitely designing generation, as is mimic_grid.py (although in the future I would also like to mimic transmission as well, so maybe it is okay to keep here). Maybe I should create that folder now after all.

If I understand, powersimdata.design/clean_capacity_scaling can go in a new powersimdata/design/generation folder.

Can we create a powersimdata/design/mimic folder where mimic_grid can go and later mimic_transmission?

[danielolsen]

I thought there was already modules in powersimdata.design related to generation. We will create the folder later then.

You are right, clean_capacity_scaling.py is definitely designing generation, as is mimic_grid.py (although in the future I would also like to mimic transmission as well, so maybe it is okay to keep here). Maybe I should create that folder now after all.

Done.

[danielolsen]

Can we create a powersimdata/design/mimic folder where mimic_grid can go and later mimic_transmission?

In my head, I'm thinking that a mimic/mimic_grid module would have functions for both mimic_generation(), mimic_transmission(), possibly also mimic_demand() etc., with one mimic_all() function or similar that would do everything. We could break them into separate files if necessary, but maybe it'd all be short enough to stay in one file and avoid another folder level.

[rouille]

Looks good

[BainanXia]

Reading through the discussion, I like the plan. Thanks for taking care of this.