Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pandas #290

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Update pandas #290

merged 1 commit into from
Sep 10, 2020

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Sep 10, 2020

Purpose

Update pandas to fix issue reading pickles created on the server.

What it does

  • drop requirements_freeze.txt since we have Pipfile.lock
  • use compatible release syntax (the ~=1.1.2) based on Daniel's comments
  • also use that syntax for psycopg2 which ends up being updated in the lock file to a new minor version
  • everything is autogenerated by pipenv except the corresponding changes in requirements.txt

Time to review

3 min

@jenhagg jenhagg self-assigned this Sep 10, 2020
@jenhagg jenhagg added this to the Movin' Out milestone Sep 10, 2020
@jenhagg
Copy link
Collaborator Author

jenhagg commented Sep 10, 2020

We'll need to update the lock file in pre/postreise too, since they include powersimdata dependencies. I'll do this shortly.

@danielolsen
Copy link
Contributor

danielolsen commented Sep 10, 2020

Shouldn't we grab the newest psycopg2? I think both places (pipfile and requirements) should list 2.8.6, not 2.8.5, right?

@jenhagg
Copy link
Collaborator Author

jenhagg commented Sep 10, 2020

I thought I'd leave the version in pipfile to try out the new syntax - both pip and pipenv will install the latest compatible version based on that (or use the lock file directly) so doesn't really matter what we put in the pipfile.

@danielolsen
Copy link
Contributor

I thought I'd leave the version in pipfile to try out the new syntax - both pip and pipenv will install the latest compatible version based on that (or use the lock file directly) so doesn't really matter what we put in the pipfile.

Cool, sounds good!

Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@jenhagg jenhagg merged commit 1519928 into develop Sep 10, 2020
@jenhagg jenhagg deleted the jon/pandas branch September 10, 2020 18:53
@ahurli ahurli mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants